Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] clarify headers in development.md #4048

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bjacobgordon
Copy link
Contributor

No description provided.

@bjacobgordon
Copy link
Contributor Author

@marbre @ScottTodd Wanting to make it easier for you to accept the changes you do like, so I've taken the first two tiny commits from #3932 and put them into their own PR as is! Hopefully that'll move along the overall doc refresh and prevent this stack of PRs from going stale.

How's this one look?

Comment on lines 248 to 252
1. Launch an interactive docker container with the required deps installed:

```shell
./utils/bazel/docker/run_docker.sh
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the newline before the code block.

You should also indent these code blocks so they appear nested under the list items:

Suggested change
1. Launch an interactive docker container with the required deps installed:
```shell
./utils/bazel/docker/run_docker.sh
```
1. Launch an interactive docker container with the required deps installed:
```shell
./utils/bazel/docker/run_docker.sh
```

First here is with the indentation, second is without:
image

# Checkout and build from source
# Environment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the title descriptive and not rely on the source file name/path to provide that context.

How about "Building from source" or "Development guide"? Then the first subsection can be "Environment setup" or "Prerequisites"

You can use

Document Title
==============

as the title if you want to use multiple <h1> headings throughout the document. I usually only have a single # (<h1>) on my pages and treat that as the title, with all other subsections starting at ## (<h2>), but that's a preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants